[이수정] Sprint 3 #39
Merged
[이수정] Sprint 3 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange script and css files)
dongqui
approved these changes
Jan 23, 2025
Collaborator
dongqui
left a comment
dongqui
left a comment
There was a problem hiding this comment.
수정님 이번 미션도 훌륭히 마무리 하셨군요! 💯
반응형 구현도 능숙하신 거 같고 깔끔하게 잘 구현하신 거 같습니다~!
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta property="og:title" content="판다 마켓" /> |
| visiblilityAgainBtn.addEventListener("click", onVisibilityAgainChange); | ||
|
|
||
| emailInputField.addEventListener("change", onSignupInputChange); | ||
| nicknameInputField.addEventListener("change", onSignupInputChange); |
Collaborator
There was a problem hiding this comment.
form 이벤트 버블링 사용을 고려해보셔도 좋습니다~!
| <div class="input-wrapper flex-sides radius-12"> | ||
| <input id="pwd-check" type="password" value="" placeholder="비밀번호를 다시 한 번 입력해주세요" /> | ||
| <input type="checkbox" alt="비밀번호 확인" id="visibility-again" /> | ||
| <button type="button" alt="비밀번호 확인 입력 보기" id="visibility-again" /> |
Collaborator
There was a problem hiding this comment.
alt는 img에만 유효합니다~!
에는 alt 대신 aria-label 같은 것들을 고려해보실 수 있어요 :)
| </p> | ||
| </form> | ||
| </main> | ||
| <script src="./scripts/login.js"></script> |
Collaborator
There was a problem hiding this comment.
여유가 되신다면 공통 로직을 뽑아서 함수로 정의해보셔도 좋을 거 같아요! 유효성 검사라던가, 비밀번호 보기 로직 같은 것들이요~ :)
| gap: 70px; | ||
| } | ||
| @media (width < 1110px) { | ||
| @media (width < 1200px) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
03. 스프린트 미션 3
요구사항
스프린트 미션 3 시안
기본 요구사항
체크리스트 [기본]
공통
랜딩 페이지
로그인, 회원가입 페이지
max-width: 400px체크리스트 [심화]
주요 변경사항
스프린트 미션 2 리뷰 반영
<p>태그는 문단을 나타낼 때만 사용으로 변경<input type="checkbox" />에서<button type="button" />사용으로 변경signup.css의 중복되는 스타일 제거스프린트 미션 3
스크린샷
랜딩 페이지 헤더 - Tablet
랜딩 페이지 헤더 - Mobile
로그인 - Tablet
회원가입 - Mobile
랜딩 페이지 공유
멘토에게